Skip to content
This repository has been archived by the owner on Oct 12, 2021. It is now read-only.

'columns_to_ignore' is unused? #391

Closed
StpMax opened this issue Jan 15, 2021 · 3 comments · Fixed by #444
Closed

'columns_to_ignore' is unused? #391

StpMax opened this issue Jan 15, 2021 · 3 comments · Fixed by #444
Labels
bug Something isn't working discussion Further discussion is required MONGO Related to mongo integration, the kind of data mongo users likely have and anything else mongo relat

Comments

@StpMax
Copy link
Contributor

StpMax commented Jan 15, 2021

I train predictor from 'concrete_strength' with 'id' column ignored. Then in predictor data_analysis_v2 i get:

{
    'columns':['water', 'coarseAggregate', 'cement', 'flyAsh', 'fineAggregate', 'superPlasticizer', 'id', 'slag', 'age', 'concrete_strength'],
    # list of all columns analysis, except 'id'
    'columns_to_ignore':{},
    'train_std_dev':{'concrete_strength': 16.257130204762287}
}

Im not seen predictors where 'columns_to_ignore' was filled. What about remove that key from data_analysis?

@StpMax StpMax added the discussion Further discussion is required label Jan 15, 2021
@George3d6 George3d6 added the bug Something isn't working label Jan 16, 2021
@George3d6
Copy link
Contributor

Hmh, columns_to_ignore is a kye in the lmd (light model data) but I'm not sure if and/or why it would be a key in the data_analysis_v2, train_std_dev and columns aren't columns in data_analysis_v2 either.

Are you getting the value above from native or from the API? It looks weird, certainly not like data_analysis_v2. If it's coming from the distribution_2 branch, please ignore it :)) , there was something weird I did there that might cause this.

Could you provide the steps to replicate?

@StpMax
Copy link
Contributor Author

StpMax commented Jan 18, 2021

That on staging branch. Here is how replicate:

from mindsdb_native import F, FileDS, Predictor
p = Predictor(name='xxx')
ds = FileDS('/home/maxs/dev/mdb/venv_new/sources/private-benchmarks/benchmarks/datasets/concrete_strength/data.csv')
p.learn(from_data=ds, to_predict=['concrete_strength'], ignore_columns=['id'])
F.get_model_data('xxx')['data_analysis_v2']

@George3d6 George3d6 added the MONGO Related to mongo integration, the kind of data mongo users likely have and anything else mongo relat label Feb 4, 2021
@George3d6
Copy link
Contributor

removed, also removed all non-col-name keys from stats_v2, and no longer used in mindsdb proper

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working discussion Further discussion is required MONGO Related to mongo integration, the kind of data mongo users likely have and anything else mongo relat
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants