Fixed IndexError & NameError #23
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[Line:43](https://github.com/mindslab-ai/faceshifter/edit/master/preprocess/preprocess.py#L43) changed `if len(dets) < 0:` to `if len(dets) <= 0:` as previously if no face is detected it would not be "caught" in `if` part. This used to result to `IndexError` [Line:52-126](https://github.com/mindslab-ai/faceshifter/edit/master/preprocess/preprocess.py#L52-126) - moved lines inside `else` fixing an `NameError` and excluding images with `dets` was less than 1
|
lgtm. Are you the same person as Ewan? |
|
Hi, yes I am sorry, I just used my work github originally so I changed
that.
Thanks
…On Wed, 21 Jul 2021 at 07:03, Changho Choi 최창호 ***@***.***> wrote:
lgtm. Are you the same person as Ewan?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#23 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AJRUZE3KFP357ICAYOOLUYLTYZPMXANCNFSM5AVUD43A>
.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Line:43 changed
if len(dets) < 0:toif len(dets) <= 0:as previously if no face is detected it would not be "caught" inifpart. This used to result inIndexErrorLine:52-126 - moved lines inside
elsefixing anNameErrorand excluding images withdetsless than 1