Fix Forge platform version detection. #1870
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…g in Forge mode, but in Vanilla mode.
Mysterious-Dev
approved these changes
Jul 29, 2022
RedNesto
approved these changes
Jul 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The MinecraftDev plugin tries to detect the minecraft version from the name of the minecraft dependency.
However in doing so it assumed that the Forge Version would always be present, which is not the case if FG is run in vanilla mode.
In that vanilla mode the version string has a different format where the "_" is after the "-", causing an exception when the version substring is about the be loaded.
This fix checks for this additional condition and prevents the crash from occuring.