Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bucket 16 stack #163

Closed
calclavia opened this issue Sep 11, 2012 · 4 comments
Closed

Bucket 16 stack #163

calclavia opened this issue Sep 11, 2012 · 4 comments

Comments

@calclavia
Copy link

I am using the latest recommend Forge source for my mod.

My mod has a custom type of bucket liquid. I am using the Forge bucket events. The bucket works fine scooping up liquid except for when the player is holding a stack of 16 buckets. It will receive the new bucket with the specified liquid but delete the 16 buckets (when supposedly there should be 15 buckets left). I think this is a Forge bug. I tried manipulating the "currentItem" variable but it didn't do anything.

I could though, "simulate" this process myself by spawning a bucket in the player's inventory though I think Forge probably should include this in the event.

@LexManos
Copy link
Member

All the bukkit event does is ask for the resulting item stack.
Its your job to determine what you should do.
Vanilla buckets dont stack. The event does nothing with adding things to the current inventory, etc..
If your items stack, its up to you to deal with how they should fill.

@Silwing
Copy link

Silwing commented Sep 11, 2012

As of 1.3 empty vanilla buckets stack up to 16. Full buckets are still not stacking.
http://www.minecraftwiki.net/wiki/Bucket

@LexManos
Copy link
Member

I totally forgot about them adding stacking buckets in 1.3. Sorry, Fixed: 8882388

@calclavia
Copy link
Author

Thank you :)

cpw added a commit that referenced this issue May 11, 2015
cpw added a commit that referenced this issue May 11, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants