Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stats issue between mods. #21

Closed
border999 opened this issue Feb 24, 2019 · 11 comments
Closed

Stats issue between mods. #21

border999 opened this issue Feb 24, 2019 · 11 comments
Assignees
Labels
bug Something isn't working mod conflict not my bug

Comments

@border999
Copy link

ExtraMeteorP/Extra-Botany#38

@border999
Copy link
Author

@YaibaToKen YaibaToKen self-assigned this Feb 24, 2019
@YaibaToKen YaibaToKen added bug Something isn't working mod conflict labels Feb 24, 2019
@YaibaToKen
Copy link
Collaborator

That definitely should not be happening. You can disable the material in the config file, meanwhile I'll look into pushing a fix.

@border999
Copy link
Author

weird thing is that I actually can't find that material in the config.

@border999
Copy link
Author

I mean, I'm looking for Oricalcum and the closest thing I find is Oricalcos.

@border999
Copy link
Author

I'll try disabling it and seeing if it helps.

@YaibaToKen
Copy link
Collaborator

The config will use whatever name was assigned to the material by the first mod when registering it. In fact, I'm not even sure how I'm loading before ExtraBotany since I set my mod to load dead last. After all, the purpose of my mod is to fill in gaps left by other mods' TiC and ConArm integration.
Also, technically speaking, this crash isn't on my side, the creator of ExtraBotany should check if the material exists and if the stats are already defined before attempting to define them. He can also set his mod to load before mine, since mine will ignore any material with ConArm stats.

@border999
Copy link
Author

I've made a similar suggestion to him. And I'm also curious why this started happening, because these mods were all working together up until a few days ago.

@YaibaToKen
Copy link
Collaborator

As you can check, Armory Expansion hasn't been updated since October 9th, 2018. It could be due to an update of the dependencies but my best bet would be something changed in ExtraBotany.

Anyway, for now, I would say remove Armory Expansion, launch the profile, switch the config option for the ExtraBotany ConArm compat off, add Armory Expansion again.
Or disable the needed materials in Armory Expansion's config file.

@border999
Copy link
Author

will attempt

@border999
Copy link
Author

https://pastebin.com/EBEKmdry
Alright man, this is really starting to look like the tinker's API is messing up. Because I'm getting the same issue from Pewter now that I pulled expansion out.

@YaibaToKen
Copy link
Collaborator

Two things, yes, TiC API should definitely not simply crash when someone tries to add a material that already exists, but, seeing as this is a known issue, mod authors should simply check if the material exists and only register if it doesn't.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working mod conflict not my bug
Projects
None yet
Development

No branches or pull requests

2 participants