Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Emotion 10 #816

Merged
merged 5 commits into from Mar 14, 2019
Merged

Emotion 10 #816

merged 5 commits into from Mar 14, 2019

Conversation

brentertz
Copy link
Member

@brentertz brentertz commented Jan 21, 2019

Description

Update to Emotion 10 and other API changes

See the migration guide for details.

Outstanding issues:

Motivation and context

Closes #813
Connects #652 #765

Screenshots, videos, or demo, if appropriate

https://emotion-10--mineral-ui.netlify.com

How to test

  1. Try the aforementioned demo
  2. Try using the css prop and the as prop on different components
  3. Take it for a test drive in CRA, in various browsers
  4. Review updated documentation and migration guide.

An npm package has been published with the next tag for anyone wishing to take it for a test drive locally. npm i mineral-ui@next

Types of changes

  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

See the migration guide for details.

Checklist

@avetisk
Copy link
Contributor

avetisk commented Mar 12, 2019

This is just awesome! When do you think this will hit the next release?

@brentertz
Copy link
Member Author

Thanks @avetisk We will publish as soon as Emotion publishes a release with the fix from emotion-js/emotion#1209

@wmonk
Copy link

wmonk commented Mar 14, 2019

Thanks @brentertz!

Was this published already? emotion-js/emotion@41f7ba1

@brentertz
Copy link
Member Author

Thanks for the heads up @wmonk We'll get right on it.

@wmonk
Copy link

wmonk commented Mar 14, 2019 via email

brentertz and others added 5 commits March 14, 2019 08:43
Co-Authored-By: Kyle Gach <kyle.gach@broadcom.com>

BREAKING CHANGE:

See our migration guide for details. https://github.com/mineral-ui/mineral-ui/blob/master/docs/v0-57-migration.md
Co-Authored-By: Kyle Gach <kyle.gach@broadcom.com>
* Extract theme override and SSR tests as they require @jest-environment
node

Co-Authored-By: Kyle Gach <kyle.gach@broadcom.com>
Co-Authored-By: Brent Ertz <brent.ertz@gmail.com>
@brentertz
Copy link
Member Author

This update has been published and is now available on npm as mineral-ui@0.57.0.

@wmonk
Copy link

wmonk commented Mar 14, 2019 via email

@brentertz brentertz deleted the emotion-10 branch January 21, 2020 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update to Emotion 10
4 participants