New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable minimal CircleCI setup #552
Conversation
Temporary measure until we figure out how to download and cache data on CircleCI properly.
oof, it's failing on CircleCI's server (during MineRL Gradle build), but not on my local CircleCi runs. Maybe this is because we don't have enough memory in the free Runners offered to open source projects. |
|
OK, we are ready to push this -- we've got CircleCI running on tests that don't launch Minecraft, and it takes about 2.5 minutes to finish those tests. We can try launching Minecraft when we figure out memory requirements later. |
WOO! This is great =) |
Configures a minimal CircleCI setup. I uploaded to DockerHub
a minimal Docker image bundling the Ubuntu and Java dependencies
that are required to
pip install -e .
MineRL. CircleCI pullsthis Docker image and runs
pytest
on top of it.Because the CircleCI setup is not complete, we should run both BuildKite and
CircleCI for "hybrid" testing until we complete address the issues below:
This PR adds conditional skips to some data pytests when
MINERL_DATA_ROOT
isnot set. This is because the minimal CircleCI set up doesn't download
and cache any MineRL datasets right now. I'm leaving that for future
work.
Other future work:
springulum/minerl-circleci-base
Docker imageto a shared MineRL account. (But I don't expect that we actually need to
update this image for a long time, since its just a bunch of Java / Ubuntu packages.)