Skip to content
This repository has been archived by the owner on Jun 22, 2022. It is now read-only.

dry_train and dry_eval? #39

Closed
buus2 opened this issue Feb 6, 2018 · 2 comments
Closed

dry_train and dry_eval? #39

buus2 opened this issue Feb 6, 2018 · 2 comments
Assignees

Comments

@buus2
Copy link
Contributor

buus2 commented Feb 6, 2018

I propose to exchange:

  • dry_run train_mode=False by dry_eval,
  • dry_run train_mode=True by dry_train.

In this way, the user could consciously choose if:

  • he/she wants to only evaluate results from in-house solution to quickly check if everything (including paths to solutions and data) is set correctly,
  • he/she wants to spend a lot of time to re-train the in-house solution and save it in his/her favourite path.

Also, after these exchanges the readmes should become more understandable.

Alternatively, I propose to exchange train_mode with only_eval/eval_only.

@jakubczakon
Copy link
Collaborator

I like the idea of two options.

It is changed now, waiting for PR to merge.

@kamil-kaczmarek
Copy link
Member

@buus2 @jakubczakon merged (#42 )

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants