Skip to content
This repository has been archived by the owner on Jun 22, 2022. It is now read-only.

subproblem inference working in dry and submit modes, added dry_run a… #42

Merged
merged 3 commits into from
Feb 9, 2018

Conversation

jakubczakon
Copy link
Collaborator

added config processing to inference experiment dir path if user doesn't specify it
refactored user interaction with dry_run to dry_train and dry_eval

Copy link
Member

@kamil-kaczmarek kamil-kaczmarek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. dry_train, dry_run: If we do it in whales, we should also do it in fashion mnist.

  2. Maybe cloud_mode should be renamed to use_neptune_cloud

  3. Is dev_mode used in any place?

@jakubczakon @buus2 What do you think?

@jakubczakon
Copy link
Collaborator Author

  1. dry_train dry_eval is just an adapter on top of dry_run and it should work with both.
  2. agreed
  3. not sure, it is more for us

@buus2
Copy link
Contributor

buus2 commented Feb 9, 2018

@kamil-kaczmarek
ad 1) Agree, we should be consistent.
ad 2) Agree.
ad 3) I don't know what it is for.

@kamil-kaczmarek kamil-kaczmarek merged commit 7518598 into master Feb 9, 2018
@kamil-kaczmarek kamil-kaczmarek deleted the feature_request-37_39 branch February 9, 2018 18:47
This was referenced Feb 9, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants