This repository has been archived by the owner on Jun 22, 2022. It is now read-only.
removed suffixes #110
Merged
removed suffixes #110
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jakubczakon
reviewed
Oct 5, 2018
steppy/base.py
Outdated
| if self._name_unique(): | ||
| _ALL_STEPS_NAMES.append(self.name) | ||
| else: | ||
| raise ValueError('Step with name "{}", already exist. You must assign unique Step name. ' |
There was a problem hiding this comment.
@kamil-kaczmarek I think this will cause error when I do the following.
Create pipeline1 with step resize
Create independent pipeline2 with step resize
This happens when I have train() where I define pipeline and later in evaluate() I also define pipeline.
I think in order to deal with that we may need to drop _ALL_STEPS_NAMES altogether.
There was a problem hiding this comment.
in this case we will not provide Users with any warning when they create several steps with name my_model -> new Step will simply overwrite previous one.
… two names are the same raise an error, simplified error logs
|
@jakubczakon corrections ready |
kamil-kaczmarek
pushed a commit
that referenced
this pull request
Oct 5, 2018
This reverts commit 520a17a.
kamil-kaczmarek
pushed a commit
that referenced
this pull request
Oct 5, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.