Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix flickering when updatig new tile (attempt 2) #387

Conversation

Emojigit
Copy link
Contributor

@Emojigit Emojigit commented Jun 7, 2024

Finally fixed the issue... *sigh* This PR is ready for review.

You can test it on my map server - you can see it updating by monitoring network requests.

@coveralls
Copy link

coveralls commented Jun 7, 2024

Pull Request Test Coverage Report for Build 9418311531

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 67.636%

Totals Coverage Status
Change from base Build 9405508814: 0.0%
Covered Lines: 907
Relevant Lines: 1341

💛 - Coveralls

@BuckarooBanzay BuckarooBanzay added the enhancement New feature or request label Jun 16, 2024
@BuckarooBanzay
Copy link
Member

so, do i get this right: this was caused by multiple calls to the onload function, right? 🤔

@BuckarooBanzay BuckarooBanzay merged commit ff1b0dc into minetest-mapserver:master Jun 16, 2024
3 checks passed
@Emojigit
Copy link
Contributor Author

Emojigit commented Jun 16, 2024

so, do i get this right: this was caused by multiple calls to the onload function, right? 🤔

Yeah, that's true. Leaflet changes the opacity every time onload gets called, i.e., a new tile is loaded.

One thing I forgot to implement: remove the onerror call too, and do such cleanup on onerror too

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants