Fix typo in wieldview #56
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
causing #55
|
Note: I just edited the lines in github editor without testing. |
VanessaE
reviewed
Jun 26, 2021
| @@ -69,12 +69,12 @@ end | |||
| minetest.register_on_joinplayer(function(player) | |||
| local name = player:get_player_name() | |||
| wieldview.wielded_item[name] = "" | |||
There was a problem hiding this comment.
you use pname below in a couple places now, but did you also mean to use it here (70, 71), and below (77)?
There was a problem hiding this comment.
minetest.after() passes the third parameter "name" (line 77) as parameter to the nameless function(pname)...end call in line 72.
Inside of function(pname) only the pname is used.
Inside of minetest.register_on_joinplayer() still "name" is used.
|
the additional |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
causing #55