Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix crash when gate got deleted while it's moving #22

Merged
merged 2 commits into from
Apr 29, 2023

Conversation

Niklp09
Copy link
Member

@Niklp09 Niklp09 commented Apr 26, 2023

Fixes Archtec-io/bugtracker#33 and #17

2023-04-26 19:25:14: ERROR[Main]: ServerError: AsyncErr: Lua: Runtime error from mod 'default' in callback environment_Step(): ...netest-5.7.0/bin/../mods/castle_gates/gate_functions.lua:441: attempt to index a nil value
2023-04-26 19:25:14: ERROR[Main]: stack traceback:
2023-04-26 19:25:14: ERROR[Main]: 	...netest-5.7.0/bin/../mods/castle_gates/gate_functions.lua:441: in function 'func'
2023-04-26 19:25:14: ERROR[Main]: 	.../minetest/minetest-5.7.0/bin/../builtin/common/after.lua:20: in function <.../minetest/minetest-5.7.0/bin/../builtin/common/after.lua:5>
2023-04-26 19:25:14: ERROR[Main]: 	...minetest/minetest-5.7.0/bin/../builtin/game/register.lua:446: in function <...minetest/minetest-5.7.0/bin/../builtin/game/register.lua:432>

and a second crash

2023-04-27 20:18:12: ERROR[Main]: ServerError: AsyncErr: Lua: Runtime error from mod 'castle_gates' in callback item_OnPlace(): ...ik/mt-server/bin/../mods/castle_gates/gate_functions.lua:217: attempt to index local 'adjacent_def' (a nil value)
2023-04-27 20:18:12: ERROR[Main]: stack traceback:
2023-04-27 20:18:12: ERROR[Main]:       ...ik/mt-server/bin/../mods/castle_gates/gate_functions.lua:217: in function 'get_door_layout'
2023-04-27 20:18:12: ERROR[Main]:       ...ik/mt-server/bin/../mods/castle_gates/gate_functions.lua:375: in function 'on_rightclick'
2023-04-27 20:18:12: ERROR[Main]:       /home/nik/mt-server/bin/../builtin/game/item.lua:313: in function </home/nik/mt-server/bin/../builtin/game/item.lua:306>

@SmallJoker
Copy link
Member

This is an error, not a crash. Reviewed the PR ignoring whitespace changes; looks good.

@SmallJoker SmallJoker merged commit c4316a0 into minetest-mods:master Apr 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants