Skip to content
This repository has been archived by the owner on Aug 9, 2023. It is now read-only.

crafts with minetest.itemstring_with_palette output not coloring correctly in craft guide #18

Closed
wsor4035 opened this issue Apr 6, 2021 · 8 comments
Labels
enhancement New feature or request

Comments

@wsor4035
Copy link
Contributor

wsor4035 commented Apr 6, 2021

as found here, https://github.com/minetest/minetest/blob/master/doc/lua_api.txt#L762-L769 registering a similar craft will not show the proper color in the crafting guide, but will show the proper color in crafting grid when you go to craft the item

@wsor4035 wsor4035 changed the title crafts with minetest.itemstring_with_palette crafts with minetest.itemstring_with_palette output not coloring correctly in craft guide Apr 6, 2021
@kilbith
Copy link
Collaborator

kilbith commented Apr 6, 2021

Do you have an example recipe to show me? I never used color palette.

@wsor4035
Copy link
Contributor Author

wsor4035 commented Apr 6, 2021

the project im currently working is not released yet, however i would assume the craft linked above, https://gist.github.com/juhdanad/433a0aa7094ae0dceaf00924d6fd1e3b and minetest/minetest#5640 (comment) for textures combined could make a simple demo mod, if you wish i could put it together

@kilbith
Copy link
Collaborator

kilbith commented Apr 6, 2021

Give me this mod.

@kilbith kilbith added the enhancement New feature or request label Apr 6, 2021
@wsor4035
Copy link
Contributor Author

wsor4035 commented Apr 6, 2021

https://github.com/wsor4035/i3_color_demo there, put together
image

@kilbith
Copy link
Collaborator

kilbith commented Apr 6, 2021

Thanks for the help.

Unfortunately, this is impossible to support without weird hacks, and even then, the support would be very partial.

There is no way to get the palette dimensions from a mod, there is no way to get a color from a pixel, and a proper displaying would need the ability to create a new item or to modify an item definition at runtime.

@wsor4035
Copy link
Contributor Author

wsor4035 commented Apr 6, 2021

ah, thanks for looking at it, should I file a issue for it, or do you already have that covered?

@kilbith
Copy link
Collaborator

kilbith commented Apr 11, 2021

Support added: 7a48b93

@kilbith kilbith closed this as completed Apr 11, 2021
@wsor4035
Copy link
Contributor Author

Thank you

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants