Skip to content
This repository has been archived by the owner on Aug 9, 2023. It is now read-only.

[bug]: registering aliases can cause minetest crash when something is searched in i3 #68

Closed
wsor4035 opened this issue Apr 24, 2022 · 3 comments
Labels
bug Something isn't working

Comments

@wsor4035
Copy link
Contributor

Describe the bug
trying to search for anything crashes minetest. see mt-mods/unifieddyes#7

To Reproduce
use a game without the dye mod
add

minetest.register_alias("dye:light_red",  "dye:pink")
minetest.register_alias("dye:medium_orange", "dye:brown")

enable mod, try to search something, watch the game crash

Additional context

  • Mod version? Release and git
  • Engine version? 5.5.0
  • LuaJIT enabled? yes
  • Operating system? windows
  • Did you try to disable other mods except i3? no, not needed.

error stack

AsyncErr: Lua: Runtime error from mod 'i3' in callback on_playerReceiveFields(): (load):104: bad argument #2 to 'translate' (string expected, got nil)
stack traceback:
	[C]: in function 'translate'
	(load):104: in function 'search'
	(load):330: in function 'rcp_fields'
	(load):445: in function <(load):411>
	...st\minetest-5.5.0-win64\bin\..\builtin\game\register.lua:425: in function <...st\minetest-5.5.0-win64\bin\..\builtin\game\register.lua:409>
wsor4035 added a commit to mt-mods/unifieddyes that referenced this issue Apr 24, 2022
@kilbith
Copy link
Collaborator

kilbith commented Apr 24, 2022

I can't seem to reproduce it. More information needed.

Is unifieddyes enabled?

@wsor4035
Copy link
Contributor Author

wsor4035 commented Apr 24, 2022

minimally reproducible example use void game + i3 + unifieddyes commit (https://github.com/mt-mods/unifieddyes/tree/ed895734f29c4fb214a82bb3bb2ac123b77fdd2e) (pre me adding a work around), then apply the latest commit and notice it doesnt crash anymore

@kilbith
Copy link
Collaborator

kilbith commented Apr 24, 2022

Indeed that happens when unifieddyes is enabled, you should have mentionned that.

312da62

@kilbith kilbith closed this as completed Apr 24, 2022
@kilbith kilbith added the bug Something isn't working label Apr 24, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants