-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Master real fix translation #16
Master real fix translation #16
Conversation
* if translation is not supported use english on compat/mtg.lua * improved the code of translation of the already init.lua * this solves: closes minetest-mods#13 * this solves: closes https://codeberg.org/minenux/lavastuff/issues/1 * close https://codeberg.org/minenux/lavastuff/issues/1
* real fix for minetest-mods#13 * use native translator or intlib property as must be, but mock if both fails
* autodetect mod name from minetest api * added only intllib in depends.txt for older 0.4.X, mod.conf its for 5+ so due 5+ has built in internationalization its not necesary in that file
Co-authored-by: LoneWolfHT <lonewolf04361@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can fix the luacheck warnings by adding intllib
and gettext
to the .luacheckrc
https://github.com/minetest-mods/lavastuff/runs/5159255069?check_suite_focus=true#step:4:13
but intllib its optional .. how can i managed if its only for 0.4.17 cos its pretty the most played protocol (including the out released 5.5 as pointed here: https://forum.minetest.net/viewtopic.php?p=406217#p406217 ) ? |
i dont know how to avoid the usage of those variables.. but he suggested to just put those .. minetest-mods#16 (comment)
done |
Oops, didn't see this @mckaygerhard you forgot to add a |
also added ',' at the en of the line
done!, sorry about the ',' |
Thanks for this, sorry I took so long! |
dont worry .. we are all busy also.. |
already tested, previus fix for you does not work, also generated an error