Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Master real fix translation #16

Merged
merged 9 commits into from
Feb 24, 2022

Conversation

mckaygerhard
Copy link
Contributor

already tested, previus fix for you does not work, also generated an error

screenshot_20220119_161927

mckaygerhard added 3 commits October 19, 2021 20:07
* if translation is not supported use english on compat/mtg.lua
* improved the code of translation of the already init.lua
* this solves: closes minetest-mods#13
* this solves: closes https://codeberg.org/minenux/lavastuff/issues/1
* close https://codeberg.org/minenux/lavastuff/issues/1
* real fix for minetest-mods#13
* use native translator or intlib property as must be, but mock if both fails
init.lua Outdated Show resolved Hide resolved
init.lua Outdated Show resolved Hide resolved
init.lua Outdated Show resolved Hide resolved
Герхард PICCORO Lenz McKAY added 2 commits February 2, 2022 18:02
* autodetect mod name from minetest api
* added only intllib in depends.txt for older 0.4.X, mod.conf its for 5+
  so due 5+ has built in internationalization its not necesary in that file
init.lua Outdated Show resolved Hide resolved
init.lua Outdated Show resolved Hide resolved
init.lua Outdated Show resolved Hide resolved
Герхард PICCORO Lenz McKAY and others added 2 commits February 6, 2022 23:05
Copy link
Collaborator

@LoneWolfHT LoneWolfHT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can fix the luacheck warnings by adding intllib and gettext to the .luacheckrc

https://github.com/minetest-mods/lavastuff/runs/5159255069?check_suite_focus=true#step:4:13

@mckaygerhard
Copy link
Contributor Author

You can fix the luacheck warnings by adding intllib and gettext to the .luacheckrc

https://github.com/minetest-mods/lavastuff/runs/5159255069?check_suite_focus=true#step:4:13

but intllib its optional .. how can i managed if its only for 0.4.17 cos its pretty the most played protocol (including the out released 5.5 as pointed here: https://forum.minetest.net/viewtopic.php?p=406217#p406217 ) ?

i dont know how to avoid the usage of those variables.. but he suggested to just put those .. minetest-mods#16 (comment)
@mckaygerhard
Copy link
Contributor Author

done

@LoneWolfHT
Copy link
Collaborator

LoneWolfHT commented Feb 14, 2022

Oops, didn't see this

@mckaygerhard you forgot to add a , at the end of your additions.
I think intllib should go in the Other Mods section too

@mckaygerhard
Copy link
Contributor Author

done!, sorry about the ','

@LoneWolfHT LoneWolfHT merged commit 3eacc17 into minetest-mods:master Feb 24, 2022
@LoneWolfHT
Copy link
Collaborator

Thanks for this, sorry I took so long!

@mckaygerhard mckaygerhard deleted the master-fix-translation branch February 24, 2022 11:50
@mckaygerhard
Copy link
Contributor Author

dont worry .. we are all busy also..

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants