Consolidate horizontal rules getters #602
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TurkeyMcMac
force-pushed
the
fourdir-consolidation
branch
from
c9384e4
to
7f4422f
Compare
I didn't get to doing this myself but what about exhaustively dumping all matching rules and then comparing it before and after this PR. |
|
That sounds good. The rules may not be exactly the same for the straight insulated wires, but it shouldn't matter since they're symmetrical. |
|
You can test with this patch. Most of the tests will print "OK" to the error log. mesecons_insulated will dump some rules to the error log that do not match each other. You can visually verify that these rules are actually equivalent. |
TurkeyMcMac
force-pushed
the
fourdir-consolidation
branch
from
7f4422f
to
3322af8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are several different components that can be rotated around the Y axis. This PR consolidates all their rules getter functions using a new API function. This has the added benefit of making them all use lookup tables instead of repeated rotation, which is probably faster and creates less garbage. I think I have noticed a minor performance increase.
I have tested that the affected nodes still work, but it would be good if someone could verify this.