Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

output of print() goes to the server log. #626

Closed
fluxionary opened this issue Nov 14, 2022 · 2 comments · Fixed by #633
Closed

output of print() goes to the server log. #626

fluxionary opened this issue Nov 14, 2022 · 2 comments · Fixed by #633

Comments

@fluxionary
Copy link
Contributor

this partially intersects w/ #388, but i don't think it's entirely a dupe.

on public servers, having the output of print() go to the server log is worse than useless. players cannot see it, and it can clog up the log w/ a lot of spurious, unfilterable garbage.

at the very least, there should be an option to disable the output that servers can enable. if others agree on that, i can create a PR.

@Desour
Copy link
Contributor

Desour commented Nov 16, 2022

👍 It's bad that print writes into log and server terminal, even on public servers.

Suggestion: Add a setting (default false) that makes it a no-op. (Setting, and not minetest.is_singleplayer(), because users otherwise get confused on why their luacontroller doesn't work on their (local) server.)

@TurkeyMcMac
Copy link
Contributor

Maybe print could call a separate function write_to_terminal after formatting its arguments. write_to_terminal would be a no-op by default, but it could be overriden by the LuaController code to write to a digiline device or something.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants