Fix strange placement behavior for non-default Stairs+ nodes #168
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Luacheck is failing because of _ being unused? Somebody should fix luacheck 8-) |
Panquesito7
reviewed
Dec 18, 2020
Removing everything from the first underscore blows up when the mod name has an underscore itself. Solve by extracting the category as the part of the name that begins after the colon and ends at the first underscore. As a bonus, this should make it easier to place nodes in the same category even if they are from different mods.
Oblomov
force-pushed
the
stairs-placement-fix
branch
from
49c823c
to
a0c5390
Compare
|
This fixed the issues from #167, thanks 👍 |
Calinou
reviewed
Dec 28, 2020
Calinou
reviewed
Dec 28, 2020
Calinou
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removing everything from the first underscore blows up when the mod name
has an underscore itself. Solve by extracting the category as the part
of the name that begins after the colon and ends at the first
underscore. As a bonus, this should make it easier to place nodes in the
same category even if they are from different mods.
This should fix #167