Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disallow rotation of garage door #36

Merged
merged 5 commits into from
Jul 18, 2024
Merged

Disallow rotation of garage door #36

merged 5 commits into from
Jul 18, 2024

Conversation

Niklp09
Copy link
Member

@Niklp09 Niklp09 commented Jun 17, 2024

Doesn't happen anymore
image

@SmallJoker
Copy link
Member

  1. my_sliding_doors:door2a2 does not rotate properly.
  2. my_future_doors:door2a cannot be rotated but would probably look good if enabled.

@Niklp09
Copy link
Member Author

Niklp09 commented Jun 21, 2024

  1. fixed
  2. I don't think so
    image

@SmallJoker
Copy link
Member

Strange. my_sliding_doors:jpanel_corner_* do not rotate properly either. I suppose the reason for that is that they're not using the MTG doors API (if available).

@Niklp09 Niklp09 requested a review from SmallJoker July 12, 2024 19:27
@SmallJoker
Copy link
Member

@Niklp09 my_sliding_doors:jpanel_corner_* do not rotate properly either. Either restrict the screwdriver actions too, or use on_rotate to set the node above/below to the same param2.

@Niklp09
Copy link
Member Author

Niklp09 commented Jul 13, 2024

@SmallJoker Thanks, fixed.

SmallJoker
SmallJoker approved these changes Jul 13, 2024
View reviewed changes
Copy link
Member

@SmallJoker SmallJoker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works. Will merge in a few days unless there are objections.

@SmallJoker SmallJoker merged commit 79547ed into master Jul 18, 2024
2 checks passed
@Niklp09 Niklp09 deleted the no_garage_door_rotation branch July 18, 2024 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SmallJoker SmallJoker SmallJoker approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Niklp09 @SmallJoker