Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add new warp sound #29

Merged
merged 3 commits into from
Jan 21, 2020
Merged

Add new warp sound #29

merged 3 commits into from
Jan 21, 2020

Conversation

Panquesito7
Copy link
Member

  • Replaces the old warp sound (whoosh.ogg).

tpr_warp.ogg is licensed under CC BY-SA 4.0 International.
@ChaosWormz, your review would be appreciated. 🙂

@Panquesito7
Add new warp sound
a835a03 
Replaces the old warp sound.
ChaosWormz
ChaosWormz approved these changes Jan 21, 2020
View reviewed changes
Copy link
Collaborator

@ChaosWormz ChaosWormz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Had to do some tweaks to the sound, ie, mixing it to mono, like woosh.ogg was. and removed trailing blank space,

@Panquesito7 Panquesito7 added One approval ✔️ Approved; waiting for merge and removed Review required 💬 Not required to merge labels Jan 21, 2020
@Panquesito7 Panquesito7 merged commit b418b67 into master Jan 21, 2020
@Panquesito7
Copy link
Member Author

@ChaosWormz, thanks! 🙂

@Panquesito7 Panquesito7 deleted the new_warp_sound branch January 21, 2020 22:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChaosWormz ChaosWormz ChaosWormz approved these changes

Assignees
No one assigned
Labels
Medium priority ❕ Attention needed One approval ✔️ Approved; waiting for merge Sounds 🔊
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Panquesito7 @ChaosWormz