Merge pull request #86 from VanessaE/leak_inv

avoid "leaking" detached inventories to other players
minetest-mods · Nov 27, 2016 · 41e9d43 · 41e9d43
2 parents 8073a3d + 029d5c4
commit 41e9d43
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 3 deletions.
diff --git a/bags.lua b/bags.lua
@@ -76,7 +76,8 @@ end)
 
 minetest.register_on_joinplayer(function(player)
 	local player_inv = player:get_inventory()
-	local bags_inv = minetest.create_detached_inventory(player:get_player_name().."_bags",{
+	local player_name = player:get_player_name()
+	local bags_inv = minetest.create_detached_inventory(player_name.."_bags",{
 		on_put = function(inv, listname, index, stack, player)
 			player:get_inventory():set_stack(listname, index, stack)
 			player:get_inventory():set_size(listname.."contents",
@@ -127,7 +128,7 @@ minetest.register_on_joinplayer(function(player)
 		allow_move = function(inv, from_list, from_index, to_list, to_index, count, player)
 			return 0
 		end,
-	})
+	}, player_name)
 	for i=1,4 do
 		local bag = "bag"..i
 		player_inv:set_size(bag, 1)

diff --git a/callbacks.lua b/callbacks.lua
@@ -43,7 +43,7 @@ minetest.register_on_joinplayer(function(player)
 			minetest.sound_play("electricity",
 					{to_player=player_name, gain = 1.0})
 		end,
-	})
+	}, player_name)
 	refill:set_size("main", 1)
 end)
 

diff --git a/depends.txt b/depends.txt
@@ -1,3 +1,4 @@
+default
 creative?
 sfinv?
 intllib?