Skip to content
This repository has been archived by the owner on May 13, 2024. It is now read-only.

Use SDL2 by default #209

Merged
merged 2 commits into from Dec 17, 2023
Merged

Use SDL2 by default #209

merged 2 commits into from Dec 17, 2023

Conversation

numberZero
Copy link
Contributor

Closes #206.

@numberZero numberZero marked this pull request as draft July 2, 2023 19:16
@numberZero
Copy link
Contributor Author

numberZero commented Jul 2, 2023 •
edited

Mingw+SDL will apparently require uploading an SDL build to http://minetest.kitsunemimi.pw/. @sfan5 is that yours?

UPD: MinGW+SDL CI is in master by now.

ndren
ndren reviewed Jul 26, 2023
View reviewed changes
Copy link
Contributor

@ndren ndren left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think lowercase sdl2 was the correct formatting in Brew (the way it was before): https://github.com/Homebrew/homebrew-core/pkgs/container/core%2Fsdl2

@ndren
Copy link
Contributor

ndren commented Jul 26, 2023

Sorry for the weird formatting, I'm basically suggesting s/SDL2/sdl2 in MacOS CI.

@numberZero
Use SDL2 by default
b845c5f 
Except of Android and macOS, for now
@numberZero numberZero marked this pull request as ready for review November 3, 2023 16:42
@numberZero
Copy link
Contributor Author

Rebased.
Now with all the CI already in place, it’s a very small change.

rubenwardy
rubenwardy approved these changes Dec 17, 2023
View reviewed changes
Copy link
Member

@rubenwardy rubenwardy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I deleted my cmake cache and clean built, uses SDL as expected. EndeavourOS Linux

sfan5
sfan5 reviewed Dec 17, 2023
View reviewed changes
scripts/ci-build-mingw.sh Outdated Show resolved Hide resolved
@sfan5 sfan5 merged commit 9a439a3 into minetest:master Dec 17, 2023
14 checks passed
@grorp grorp mentioned this pull request Jan 15, 2024
Open
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sfan5 sfan5 sfan5 left review comments

@ndren ndren ndren left review comments

@rubenwardy rubenwardy rubenwardy approved these changes

Assignees
No one assigned
Labels
One approval
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

When default to SDL?
4 participants
@numberZero @ndren @sfan5 @rubenwardy