Refactor SDL input code to fix menu exit

[ndren]

Continued from #144, includes KEY_RETURN.

[ndren]

@paradust7 Please let me know if you have some feedback for this approach. Thanks!

[ndren]

This PR is ready for review. I've fixed all the regressions I could find.

[sfan5]

Why are we adding a new, different method now? We have a working IME model that (as far as I can tell) SDL just needs to use, please read #144 (comment).

[Desour]

Why are we adding a new, different method now? We have a working IME model that (as far as I can tell) SDL just needs to use

Sorry, that was an unnecessary idea by me, I was stupid and didn't read carefully enough.
The idea was that the driver could be more independent of any gui systems by offering a function that en-/disables text-input, and that key events are not fired for text keys if in text input mode.

please read #144 (comment).

If I understand correctly, starting and stopping SDL text input doesn't solve the issue. It just en-/disables the extra text events. But the issue is that there are also key events that cause keybindings in minetest to be triggered, i.e. inventory key. According to libsdl-org/SDL#2897 (and libsdl-org/SDL#4739), text input is on by default anyway.

[ndren]

@sfan5 I went back to the original plan, thanks. Let me know how it looks now.
@Desour Although disabling/enabling does not do anything by itself, it does mean that the keyboard shortcut events for unicode keys (including the one for the inventory!) can be thrown away when something is in focus (so the other unicode handler deals with it), hence solving the issue.

[ndren]

Side note: CI decided not to run (cancelled itself) on macos. Not sure why or how to fix.

[ndren]

I squashed the commits together, hopefully now CI decides to run.

[ndren]

CI builds well now, let me know if there's anything else to be done.

[ndren]

@sfan5 I've had to remove const when adding static, let me know if that works.

[sfan5]

@Desour if you have the time, can you confirm for me whether this works?

[Desour]

Tested.
Works fine otherwise.

[Desour]

I've had to remove const when adding static, let me know if that works.

Btw. just FYI, @ndren, the const after a member function is for the implicit this ptr (and hence also all non-static class member variables), which doesn't exist for static member functions.

[ndren]

@Desour Thanks for the clarification and testing!

[ndren]

@Desour Can you confirm this works with the new SDL check included?

[Desour]

👍 Works.
(Code is also fine, btw..)