This repository has been archived by the owner on May 13, 2024. It is now read-only.
File format loader fixes #237
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
numberZero
reviewed
Sep 20, 2023
True. |
Desour
reviewed
Sep 22, 2023
There was a problem hiding this comment.
It would be good to value-init headers before reading them, e.g. in the BMP loader, for the case read() doesn't read a full header.
We should at some point replace some of these loaders with libraries, e.g. sdl2_image for images.
Haven't tested. Unittests would be good.
Even when an error was encountered ::load() would still attempt to assemble the mesh, this was a pretty big problem.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I gave up on the .x loader since there's too many bugs (there are remaining ones).
Although I tried to be careful testing is welcome to check that I didn't accidentally break any valid models.