This repository has been archived by the owner on May 13, 2024. It is now read-only.
Fix 10 MSVC narrowing cast warnings from irrString and irrArray #261
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The irrString implementation doesn't allow constructing a string with a size that would exceed a u32, so it should be safe to narrow the size of the underlying STL container back to a u32. This fixes 5 narrowing cast warnings from Visual Studio 17 2022.
This fixes 5 narrowing cast warnings from Visual Studio 17 2022.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems these data structures sizes are intended to be limited to what fits in a u32 by the current implementation, so I've resolved the warnings by casting the sizes of the underlying STL types.
I saw these warnings in a Visual Studio 17 2022 Debug build with current master.