[CSM] storage + fixes

clientmods/preview/init.lua

@@ -1,3 +1,5 @@
+local modname = core.get_current_modname() or "??"
+
 -- This is an example function to ensure it's working properly, should be removed before merge
 core.register_on_shutdown(function()
 	print("[PREVIEW] shutdown client")
@@ -38,5 +40,5 @@ core.register_chatcommand("dump", {
 })
 
 core.after(2, function()
-	print("After 2")
+	print("[PREVIEW] loaded " .. modname .. " mod")
 end)

src/script/clientscripting.cpp

@@ -22,6 +22,7 @@ with this program; if not, write to the Free Software Foundation, Inc.,
 #include "client.h"
 #include "cpp_api/s_internal.h"
 #include "lua_api/l_client.h"
+#include "lua_api/l_storage.h"
 #include "lua_api/l_sound.h"
 #include "lua_api/l_util.h"
 
@@ -53,4 +54,5 @@ void ClientScripting::InitializeModApi(lua_State *L, int top)
 	ModApiUtil::InitializeClient(L, top);
 	ModApiClient::Initialize(L, top);
 	ModApiSound::Initialize(L, top);
+	ModApiStorage::Initialize(L, top);
 }

src/script/lua_api/CMakeLists.txt

@@ -25,5 +25,6 @@ set(common_SCRIPT_LUA_API_SRCS
 set(client_SCRIPT_LUA_API_SRCS
 	${CMAKE_CURRENT_SOURCE_DIR}/l_client.cpp
 	${CMAKE_CURRENT_SOURCE_DIR}/l_mainmenu.cpp
+	${CMAKE_CURRENT_SOURCE_DIR}/l_storage.cpp
 	${CMAKE_CURRENT_SOURCE_DIR}/l_sound.cpp
 	PARENT_SCOPE)

src/script/lua_api/l_client.h

@@ -23,8 +23,7 @@ with this program; if not, write to the Free Software Foundation, Inc.,
 
 #include "lua_api/l_base.h"
 
-class ModApiClient:
-	public ModApiBase
+class ModApiClient: public ModApiBase
 {
 private:
 	// get_current_modname()

src/script/lua_api/l_util.cpp

@@ -532,12 +532,6 @@ void ModApiUtil::InitializeClient(lua_State *L, int top)
 
 	API_FCT(get_us_time);
 
-	API_FCT(setting_set);
-	API_FCT(setting_get);
-	API_FCT(setting_setbool);
-	API_FCT(setting_getbool);
-	API_FCT(setting_save);
-
 	API_FCT(parse_json);
 	API_FCT(write_json);
 

src/server.cpp

@@ -3400,7 +3400,7 @@ void Server::getModNames(std::vector<std::string> &modlist)
 		modlist.push_back(it->name);
 }
 
-const std::string Server::getBuiltinLuaPath()
+std::string Server::getBuiltinLuaPath()
 {
 	return porting::path_share + DIR_DELIM + "builtin";
 }

src/server.h

@@ -299,7 +299,7 @@ class Server : public con::PeerHandler, public MapEventReceiver,
 	virtual const ModSpec* getModSpec(const std::string &modname) const;
 	void getModNames(std::vector<std::string> &modlist);
 	std::string getBuiltinLuaPath();
-	inline const std::string &getWorldPath() const { return m_path_world; }
+	std::string getWorldPath() const { return m_path_world; }
 	std::string getModStoragePath() const;
 
 	inline bool isSingleplayer()