Add .nomedia file to Android assets #10047
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rubenwardy
added
@ Build
rubenwardy
added
the
Trivial
MoNTE48
reviewed
Jun 18, 2020
| @@ -1043,7 +1043,7 @@ void TouchScreenGUI::applyJoystickStatus() | |||
| if (i == 4 && !m_joystick_triggers_special1) | |||
| continue; | |||
|
|
|||
| SEvent translated; | |||
| SEvent translated{}; | |||
There was a problem hiding this comment.
Not sure why this doesn't just have an empty diff?
|
Does it work on Windows? If not, MultiCraft creates this file from Java.
Wow, impossible! Where? |
|
Not sure, it may be done in the Java. I can check. I'm not sure which way is better Yes, this does work on Windows :) |
|
When worked - leave it as is. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
.nomedia files prevent images from appearing in the phone's gallery app and other places.
This file was present in the old way of extracting/building assets
To do
How to test
Use Minetest, check gallery app
Gallery apps may cache the pictures, and won't recheck
.nomedia. It also expects.nomediato be the first file, which may not happen if the folder is already indexed (crazy assumption?!) I needed to delete the Minetest folder and reextract the assets for this to work.