Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Signlike drawtype not being lit smoothly across large areas #104

Closed
VanessaE opened this issue Jun 10, 2012 · 18 comments
Closed

Signlike drawtype not being lit smoothly across large areas #104

VanessaE opened this issue Jun 10, 2012 · 18 comments
Labels
@ Client / Audiovisuals Feature request Issues that request the addition or enhancement of a feature Non-trivial A large amount of work is required to address this (sometimes to the point of being infeasible).

Comments

@VanessaE
Copy link
Contributor

When using the signlike drawtype to place objects on the ceiling or walls (in this case, two separate, smoothly-tilable images), any light from sources in the room or from a window is being distributed across those tiles very coarsely. See this screenshot for an example:

homedecor mod screenshot showing no smooth light

(Notice the ceiling "paint")

Code used to produce the ceiling covering:

minetest.register_node('homedecor:ceiling_paint', {
    description = "Textured Ceiling Paint",
    drawtype = 'signlike',
    tile_images = { 'homedecor_ceiling_paint.png' },
    inventory_image = 'homedecor_ceiling_paint_roller.png',
    wield_image = 'homedecor_ceiling_paint_roller.png',
    sunlight_propagates = true,
    paramtype = 'light',
    walkable = false,
    groups = { snappy = 3 },
    sounds = default.node_sound_leaves_defaults(),
        selection_box = {
            type = "wallmounted",
                         --wall_top = <default>
                         --wall_bottom = <default>
                         --wall_side = <default>
                        },
})
@nerzhul
Copy link
Member

nerzhul commented Feb 18, 2015

is this bug already present ?

@VanessaE
Copy link
Contributor Author

Still present in current git, also affects some other drawtypes actually (really, anything that isn't a normal cube). Signlike was just the first one I noticed at the time this was filed.

@PilzAdam PilzAdam added enhancement and removed Unconfirmed bug Bug report that has not been confirmed to exist/be reproducible labels Feb 18, 2015
@ShadowNinja ShadowNinja added Bug Issues that were confirmed to be a bug Low priority and removed enhancement labels Feb 20, 2015
@Fixer-007
Copy link
Contributor

I can confirm it, still present in git. Screenshot: http://i.imgur.com/iy4myvR.png

@paramat
Copy link
Contributor

paramat commented Feb 19, 2016

Is this not just the fact certain nodes cannot have smooth lighting?

@stormchaser3000
Copy link

paramat: voxelands has smooth lighting on nodeboxes

@ghost
Copy link

ghost commented Feb 20, 2016

Apparently it's not just nodeboxes but also nodes that are transparent? I'm trying to get CaveRealm's thin ice texture to be smoothly lit, but it seems that because it is transparent that I can not.

@Fixer-007
Copy link
Contributor

RBA said in another topic:

This is not a bug but our lighting system. slabs, stairs, all nodeboxes, plants, rails, meshnodes, etc are using internal light of the node. solids blocks calculate that for all 6 faces. So, the effect is different for them.

To make stairs for example have same lighting as solid nodes there should be added special drawtype that would use the same method. Code itself doesnt know whats "similar" to full sized node...
IMHO not easily fixeable, but i will think about possible solutions.

@paramat paramat added Not a bug The behaviour is working as intended and won't be changed. and removed Bug Issues that were confirmed to be a bug Low priority labels Apr 17, 2016
@paramat
Copy link
Contributor

paramat commented Apr 17, 2016

@VanessaE seems not a bug, only cubic nodes have smooth lighting, all else uses a single light value for the whole node.
Can this be closed?

@PilzAdam PilzAdam added Enhancement and removed Not a bug The behaviour is working as intended and won't be changed. labels Apr 17, 2016
@PilzAdam
Copy link
Contributor

@paramat don't close this, it can be seen as a feature request to improve the lighting system.

@paramat paramat added the Feature request Issues that request the addition or enhancement of a feature label Apr 17, 2016
@VanessaE VanessaE closed this as completed Aug 8, 2016
@Fixer-007
Copy link
Contributor

Fixer-007 commented Aug 8, 2016

Objection! Smooth lightning support in minetest is incomplete and needs finishing.

@rubenwardy rubenwardy reopened this Aug 8, 2016
@paramat paramat added the Non-trivial A large amount of work is required to address this (sometimes to the point of being infeasible). label Nov 25, 2016
@paramat
Copy link
Contributor

paramat commented Jan 18, 2017

This is the original issue for lack of smooth lighting on non-cubic nodes, so should be kept open.

@paramat paramat reopened this Jan 18, 2017
@paramat
Copy link
Contributor

paramat commented Jan 18, 2017

f9f6ba22-dcef-11e6-8f31-501a906f3521

Snow nodeboxes.

@numberZero
Copy link
Contributor

numberZero commented Jan 21, 2017

new smooth lighting
https://github.com/numberZero/minetest/tree/dev-light-smooth
(stairs use meshes and my system support only nodeboxes yet)
Of course there are bugs, this is WIP. It even crashes sometimes... (it seems it can’t handle nodes adjacent to an unloaded area).

@numberZero
Copy link
Contributor

Now works for mesh nodes too:
smooth-stair
Note: may impact performance!
Note: crash is not fixed yet

@Fixer-007
Copy link
Contributor

Fixer-007 commented Jan 22, 2017

Please YES. Can you make a PR? We need this badly! I will also try it out.

@numberZero
Copy link
Contributor

I can’t make a PR yet, it crashes( The reason is that in order to render a node it needs to access its surrounding, but it may not be available on the mapblock boundary. Now thinking how to work around that.

@MarkuBu
Copy link
Contributor

MarkuBu commented Jan 22, 2017

Great job

@paramat
Copy link
Contributor

paramat commented Jan 29, 2017

\0/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
@ Client / Audiovisuals Feature request Issues that request the addition or enhancement of a feature Non-trivial A large amount of work is required to address this (sometimes to the point of being infeasible).
Projects
None yet
Development

No branches or pull requests