Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused functions reported by cppcheck #10463

Merged
merged 2 commits into from Oct 5, 2020

Conversation

SmallJoker
Copy link
Member

This change removes a few (but not all) unused functions.
Some unused helper functions were not removed due to their complexity and potential of future use.

A rough list of removed things:

  • unused debug streams -> use warningstream, verboststream etc
  • unused mapgen functions -> similar code already exists
  • content/packages.cpp -> was moved entirely to Lua

To do

This PR is Ready for Review.

How to test

  1. Check whether it compiles.

This change removes a few (but not all) unused functions.
Some unused helper functions were not removed due to their complexity and potential of future use.
@SmallJoker SmallJoker added the Maintenance Tasks to keep the codebase and related parts in order, including architectural improvements label Oct 4, 2020
@SmallJoker SmallJoker changed the title Run unused functions reported by cppcheck Remove unused functions reported by cppcheck Oct 4, 2020
src/chat.cpp Show resolved Hide resolved
Copy link
Member

@sfan5 sfan5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@nerzhul
Copy link
Member

nerzhul commented Oct 5, 2020

nice !

@nerzhul nerzhul merged commit f46509d into minetest:master Oct 5, 2020
JosiahWI pushed a commit to JosiahWI/minetest that referenced this pull request Oct 17, 2020
Run unused functions reported by cppcheck

This change removes a few (but not all) unused functions.
Some unused helper functions were not removed due to their complexity and potential of future use.
@SmallJoker SmallJoker deleted the cppcheck_cleanup1 branch June 4, 2022 19:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Maintenance Tasks to keep the codebase and related parts in order, including architectural improvements One approval ✅ ◻️
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants