Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display Minetest header when menu_last_game value isn't available anymore #10751

Merged
merged 3 commits into from Dec 28, 2020

Conversation

Zughy
Copy link
Member

@Zughy Zughy commented Dec 25, 2020

Fixes #9962

To do

This PR is Ready for Review.

How to test

  • Install a game
  • Close MT having that game selected in the local tab
  • delete that game folder
  • reopen MT
  • "Minetest" header should appear

@sfan5 sfan5 added Bugfix 🐛 PRs that fix a bug Trivial The change is a trivial bug fix, documentation or maintenance change, as per the Git Guidelines labels Dec 25, 2020
Copy link
Member

@SmallJoker SmallJoker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixes the described issue.

@sfan5 sfan5 merged commit 55dba1b into minetest:master Dec 28, 2020
@Zughy Zughy deleted the display_header branch January 2, 2021 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bugfix 🐛 PRs that fix a bug One approval ✅ ◻️ Trivial The change is a trivial bug fix, documentation or maintenance change, as per the Git Guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The game header image is not displayed when restarting MT after removing a game
3 participants