Fix rotation for falling mesh degrotate nodes #11159
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Update: I've also updated the |
sfan5
changed the title
SmallJoker
approved these changes
Apr 27, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a node with
drawtype="mesh"andparamtype2="[color]degrotate"falls, the rotation of that node was wrong.Also, the drawtype test nodes in DevTest were quite buggy as well and not very useful for testing (pyramid looks the same after 90° rotation).
I fixed both this.
How to test
Place the degrotate nodes from DevTest on the ground. Use the Param2 Tool to set a rotation and/or color. Use the Falling Node Tool with the Punch key to force a fall. Test all possible variations. The color and rotation of the falling node must be the same as the color and rotation of the node.
Notifications
@numberZero