Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ContentDB: Add support for package aliases / renaming #11484

Merged
merged 1 commit into from Aug 2, 2021

Conversation

rubenwardy
Copy link
Member

@rubenwardy rubenwardy commented Jul 24, 2021

This allows users to change their usernames on ContentDB, and transferring packages between authors.

Here is GreenDimond renamed to GreenXenith

image

To do

This PR is a Ready for Review.

How to test

I don't want to introduce aliases to production ContentDB until 5.5.0 is released and mod authors are happy to only support 5.5.0+, as this will cause installs to no longer detect updates on older versions.

I tested locally using a development version of ContentDB. However, you can test by installing on of GreenXenith's mods and then adding the following to dlg_contentstore.lua:570:

if package.author == "GreenDimond" then
	package.author = "GreenXenith"
	package.aliases = {
		"GreenDimond/" .. package.name
	}
end

@rubenwardy rubenwardy added @ Content / PkgMgr @ Mainmenu Feature ✨ PRs that add or enhance a feature Maintenance Tasks to keep the codebase and related parts in order, including architectural improvements Roadmap: Needs approval The change is not part of the current roadmap and needs to be approved by coredevs beforehand. Concept approved Approved by a core dev: PRs welcomed! and removed Roadmap: Needs approval The change is not part of the current roadmap and needs to be approved by coredevs beforehand. labels Jul 24, 2021
@Pantyhose-X

This comment has been minimized.

Copy link
Member

@SmallJoker SmallJoker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rubenwardy rubenwardy merged commit bee50ca into minetest:master Aug 2, 2021
@rubenwardy rubenwardy deleted the cdb_aliases branch August 2, 2021 19:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Concept approved Approved by a core dev: PRs welcomed! @ Content / PkgMgr Feature ✨ PRs that add or enhance a feature @ Mainmenu Maintenance Tasks to keep the codebase and related parts in order, including architectural improvements One approval ✅ ◻️
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants