Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

memcpy(3) invoked with null pointer argument in src/network/networkpacket.cpp lines 66 (argument 1) and 556 (argument 2) #11798

Open
erlehmann opened this issue Nov 30, 2021 · 0 comments
Open

memcpy(3) invoked with null pointer argument in src/network/networkpacket.cpp lines 66 (argument 1) and 556 (argument 2) #11798

erlehmann opened this issue Nov 30, 2021 · 0 comments
Labels
Code quality Low priority @ Network

Comments

@erlehmann
Copy link
Contributor

Minetest version

commit 413be76

Summary

According to asan, in src/network/networkpacket.cpp lines 66 and 556, m_data.data() can be a null pointer.

I belive this to be illegal usage of memcpy(3).

Steps to reproduce

Compile minetest commit 413be76 with CXXFLAGS -fsanitize=undefined -fno-sanitize=vptr and start it.
@erlehmann erlehmann added the Unconfirmed bug Bug report that has not been confirmed to exist/be reproducible label Nov 30, 2021
@Zughy Zughy added @ Network Code quality and removed Unconfirmed bug Bug report that has not been confirmed to exist/be reproducible labels May 10, 2022
@Desour Desour mentioned this issue Sep 22, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Code quality Low priority @ Network
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add wrappers for memcpy and memset Desour/minetest
3 participants
@erlehmann @sfan5 @Zughy