Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jack O Lantern for Halloween ! #12

Closed
wants to merge 15 commits into from
Closed

Jack O Lantern for Halloween ! #12

wants to merge 15 commits into from

Conversation

Myu-Unix
Copy link

Hi dear celeron55,

I'm a newcomer in minetest-c55 development, and this is my first pull request.

It's about a Jack O Lantern block with light, it would be nice to have this block included before October release :)

Let me know what you think / what's wrong and I'll update if needed

Cheers !

@adamnew123456
Copy link

It's typically considered good practice, when working on a single feature, to roll your commits into one so that it doesn't pollute the history. See git commit --amend and git rebase. (However, don't rebase this commit - altering public history is bad).

@celeron55
Copy link
Member

Altering public history doesn't matter when you are working on a feature branch which currently is not good and know nobody has based anything on it.

@Myu-Unix
Copy link
Author

Hi guys,

I'll try to get a better understanding of git/github and minetest code before pulling requests.

Don't blame me, I'm just a newbie :p

Cheers

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants