Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lua API: Consistently use double vs. single quotes #12075

Merged
merged 1 commit into from Feb 22, 2022

Conversation

appgurueu
Copy link
Contributor

The docs sometimes use single quotes instead of double quotes for now apparent reason, which is oddly inconsistent. I decided to only use single quotes if they avoid the need for escaping of double quotes.

@ghost ghost added @ Documentation Trivial The change is a trivial bug fix, documentation or maintenance change, as per the Git Guidelines labels Feb 16, 2022
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine by me. It seems that double-quotes are largely preferred, so this change seems sensible.

@SmallJoker SmallJoker merged commit 0a0fb11 into minetest:master Feb 22, 2022
@appgurueu appgurueu deleted the fix-quote-inconsistency branch March 31, 2024 18:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
@ Documentation Trivial The change is a trivial bug fix, documentation or maintenance change, as per the Git Guidelines >= Two approvals ✅ ✅
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants