Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"put" action from register_on_player_inventory_action doesn't work when picking up an item #12108

Closed
Zughy opened this issue Mar 2, 2022 · 4 comments
Labels
Unconfirmed bug Bug report that has not been confirmed to exist/be reproducible

Comments

@Zughy
Copy link
Member

Zughy commented Mar 2, 2022

Minetest version
5.5.0
Summary

dropping an item calls take, but picking it up doesn't call put.

Steps to reproduce
minetest.register_on_player_inventory_action(function(player, action, inventory, inventory_info)
  minetest.chat_send_all(action)
end)

and pick up some items

@Zughy Zughy added the Unconfirmed bug Bug report that has not been confirmed to exist/be reproducible label Mar 2, 2022
@SmallJoker
Copy link
Member

This is because the feature in #12098 is yet not available. Picking up items is done by InvRef:add_item().

@Desour
Copy link
Member

Desour commented Mar 3, 2022

Related: #7712

@Zughy
Copy link
Member Author

Zughy commented Apr 29, 2022

Should this be closed? I find mine a lot shorter and straight to the point, but I'm not super partes

@SmallJoker
Copy link
Member

#12098 provides more information and possible implementation ideas too. Closing because it's the same underlying issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Unconfirmed bug Bug report that has not been confirmed to exist/be reproducible
Projects
None yet
Development

No branches or pull requests

3 participants