Fix memory leak in EmergeManager #12129
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sfan5
reviewed
Mar 12, 2022
|
If you plan on fixing more memory leaks it'd be okay to collect them for one big PR, by the way. No need to open one for each. |
EmergeManager keeps a copy of the BiomeGen that it creates, but never deletes it.
setupminimal
force-pushed
the
memory-leak-biomemgr
branch
from
aa62996
to
3dc1f83
Compare
|
I've just been tackling the next error Valgrind turns up each time I have a bit of free time, but that's a fair point. I have one more pull request along these lines in the work, but it's a much larger refactor to fix an ambiguous ownership issue, and I haven't spotted any other problems with Valgrind. I expect that I'll probably have it sorted out sometime next week or so. And I do appreciate your help in reviewing and merging these pull requests -- tracking down these issues has been really fun and satisfying. I'll make sure to consolidate smaller pull requests in the future. |
sfan5
approved these changes
Mar 12, 2022
sfan5
added
Trivial
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
EmergeManagerkeeps a pointer to aBiomeGenthat it creates and then hands (a copy of) out to each worker thread, but neverdeletes theBiomeGen.To do
This PR is Ready for Review.
How to test
This fix can be verified with Valgrind by creating, entering, and then leaving a world.