Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Client-side translations: gettext and plural support #12446

Closed
wants to merge 14 commits into from

Conversation

Ekdohibs
Copy link
Member

This PR is a rebase of #10451.


Add gettext support for client-side translations. This allows using existing gettext tooling, and will allow using plurals in translated strings (ngettext and the like).

Testing is needed, but the PR is otherwise complete.

@Ekdohibs Ekdohibs changed the title Translations gettext2 Client-side translations: gettext and plural support Jun 16, 2022
@sfan5 sfan5 added @ Translation Testing needed Feature ✨ PRs that add or enhance a feature labels Jun 16, 2022
@Ekdohibs
Copy link
Member Author

I added a commit for testing, and fixed a few bugs that were still there that I found.
To test:

  • add the following to po/fr/minetest.po (this is not committed, as weblate takes care of translations):
msgid "0"
msgid_plural "1"
msgstr[0] "0"
msgstr[1] "1"
  • set your locale to "fr"
  • start the devtest game and run /testtranslations.

This should test all three types of translation files, as well as plural translations for both .po and .mo files (plurals are unsupported in .tr files).

@rubenwardy rubenwardy self-requested a review June 24, 2022 20:23
@Zughy Zughy added the Rebase needed The PR needs to be rebased by its author. label Apr 9, 2023
@Zughy
Copy link
Member

Zughy commented Apr 9, 2023

@Ekdohibs please rebase
core devs: please show interest

@Zughy Zughy closed this May 14, 2023
@Wuzzy2
Copy link
Contributor

Wuzzy2 commented May 15, 2023

Was this closed due to success or due to failure?

@Zughy
Copy link
Member

Zughy commented May 15, 2023

@Wuzzy2 author has disappeared. Also, more than 30 days after having asked for a rebase

@Wuzzy2
Copy link
Contributor

Wuzzy2 commented May 16, 2023

Please add the "adoption needed" label, just in case.

@rubenwardy rubenwardy added the Adoption needed The pull request needs someone to adopt it. Adoption welcomed! label May 16, 2023
@Zughy Zughy removed the Adoption needed The pull request needs someone to adopt it. Adoption welcomed! label Jul 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature ✨ PRs that add or enhance a feature Rebase needed The PR needs to be rebased by its author. Testing needed @ Translation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants