Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add keybind to swap items between hands #12589

Conversation

LizzyFleckenstein03
Copy link
Contributor

@LizzyFleckenstein03 LizzyFleckenstein03 commented Jul 23, 2022

Adds a key binding ('F' by default) that swaps the item currently in your main hand with the one currently in your offhand,

To do

Depends on #11016 to be merged first.
Otherwise ready for review.

In the future, this should be added to android UI as well.

How to test

  1. Follow testing instructions for Dual Wielding #11016
  2. Press F while there is an item in main hand and offhand is empty, verify it works
  3. Press F while there is an item in offhand and main hand is empty, verify it works
  4. Press F while there is an item each hand, verify it works
  5. Press F to pay respects, verify it works

@Zughy Zughy added Feature ✨ PRs that add or enhance a feature @ Client / Controls / Input Roadmap: Needs approval The change is not part of the current roadmap and needs to be approved by coredevs beforehand. labels Jul 24, 2022
@erlehmann
Copy link
Contributor

F

@ghost ghost mentioned this pull request Sep 6, 2022
2 tasks
@Zughy Zughy added the Waiting (on dependency) Waiting on another PR or external circumstances (not for rebases/changes requested) label Apr 27, 2023
@Zughy Zughy closed this Feb 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
@ Client / Controls / Input Feature ✨ PRs that add or enhance a feature Roadmap: Needs approval The change is not part of the current roadmap and needs to be approved by coredevs beforehand. Waiting (on dependency) Waiting on another PR or external circumstances (not for rebases/changes requested)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants