Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix two spelling mistakes #12794

Merged
merged 1 commit into from Sep 25, 2022
Merged

Fix two spelling mistakes #12794

merged 1 commit into from Sep 25, 2022

Conversation

coldtobi
Copy link
Contributor

Spelling fix.

@SmallJoker
Copy link
Member

Very cool. Please fix more while you're at it.

@Zughy Zughy added Trivial The change is a trivial bug fix, documentation or maintenance change, as per the Git Guidelines Action / change needed Code still needs changes (PR) / more information requested (Issues) @ Documentation labels Sep 21, 2022
@coldtobi
Copy link
Contributor Author

coldtobi commented Sep 22, 2022 •
edited

Very cool. Please fix more while you're at it.

I guess that's all what lintian has found in the code :) There are a few more findings in the license text of src/util/sha2.h, but I guess this is not actionable.
(This file has a strange license… to a point where it might not be LGPL compatible (due to the advertising clause. / OpenSSL incompastiblity with LGPL.) openSSL has relicensed recently to Apache 2.0 -- I did not check if it would be possible to update the files; apache2.0 shoud be fine. Disclaimer: IANAL.)

@Zughy Zughy removed the Action / change needed Code still needs changes (PR) / more information requested (Issues) label Sep 22, 2022
@Wuzzy2 Wuzzy2 mentioned this pull request Sep 23, 2022
Open
@sfan5 sfan5 changed the title Fix spelling of specified. Fix two spelling mistakes Sep 25, 2022
@sfan5 sfan5 merged commit 7069d99 into minetest:master Sep 25, 2022
@coldtobi coldtobi deleted the fix-spelling-specified branch October 28, 2022 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
@ Documentation Trivial The change is a trivial bug fix, documentation or maintenance change, as per the Git Guidelines
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@coldtobi @SmallJoker @sfan5 @Zughy