Fix broken fixed_virtual_joystick #12814
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If still uses u32, m_screensize will yield a big value (underflow) when used as a subtrahend. ETIE_MOVED is allowed to be run if joystick's ID is available and virtual joystick is fixed. Add .0f for some float values.
sfan5
changed the title
TurkeyMcMac
approved these changes
Nov 26, 2022
|
Thank you for the merge! |
appgurueu
pushed a commit
to appgurueu/minetest
that referenced
this pull request
May 2, 2023
…netest#12814) If still uses u32, m_screensize will yield a big value (underflow) when used as a subtrahend. ETIE_MOVED is allowed to be run if joystick's ID is available and virtual joystick is fixed. Add .0f for some float values.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal of the PR
Restore the behaviour of fixed virtual joystick as originally implemented.
How does the PR work?
This PR fixes some C++ implementation issues of the behaviour:
m_screensizeasu32produced underflow when it is used as a subtrahend.Does it resolve any reported issue?
Yes, this PR tries to fixes #12002.
Does this relate to a goal in the roadmap?
Probably, this PR tries to fix gameplay/control-related bug.
To do
This PR is Ready for Review.
How to test
fixed_virtual_joystick.