Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document Android controls #13061

Merged
merged 35 commits into from May 11, 2023
Merged

Document Android controls #13061

merged 35 commits into from May 11, 2023

Conversation

oong819
Copy link
Contributor

@oong819 oong819 commented Dec 21, 2022

Add compact, short information about your PR for easier understanding:

To do

This PR is Ready

  • Check the information (correct?)
  • Check grammar

How to test

Check Android root directory (root is NOT required)
Check in-game

doc/README.android.md Outdated Show resolved Hide resolved
@oong819
Copy link
Contributor Author

oong819 commented Dec 22, 2022

what minimum Android version recommended for Minetest?

@rollerozxa
Copy link
Member

Minimum is API level 14 (Android 4.1), but there is no recommended version (other than one that still gets security updates by Google, Android 10+)

@oong819
Copy link
Contributor Author

oong819 commented Dec 22, 2022

Changed

@oong819
Copy link
Contributor Author

oong819 commented Dec 24, 2022

forgot to change API level, now changed

@oong819 oong819 mentioned this pull request Dec 26, 2022
@oong819
Copy link
Contributor Author

oong819 commented Dec 28, 2022

i think the doc can be extend more, also previously waiting for review is long so i want to finish this with 1 PR

also seem like no one care the Android doc

@oong819
Copy link
Contributor Author

oong819 commented Jan 1, 2023

i think its now ready

@oong819 oong819 marked this pull request as ready for review January 1, 2023 07:51
@sfan5 sfan5 changed the title improve Android doc Document Android controls Jan 4, 2023
doc/Android.md Outdated Show resolved Hide resolved
doc/Android.md Outdated Show resolved Hide resolved
doc/Android.md Outdated Show resolved Hide resolved
doc/Android.md Outdated Show resolved Hide resolved
doc/Android.md Outdated Show resolved Hide resolved
@SmallJoker
Copy link
Member

There seem to be a few grammatical and stylistic issues in the document. Might it be possible for you to run a grammar checker on this file to improve the quality?

oong819 and others added 3 commits January 10, 2023 12:53
The changes to the minimal system requirements are intentional. Media cache, Minetest Game and package download/install requires more than just 20 MB of storage.
@oong819
Copy link
Contributor Author

oong819 commented Jan 10, 2023

Minetest dont use Android widget view right?

@oong819
Copy link
Contributor Author

oong819 commented Feb 2, 2023

final change: rename file from "Android.md" to "android.md" cuz other doc file are all lowercase, only special file have some uppercase character

@oong819
Copy link
Contributor Author

oong819 commented Mar 7, 2023

if no problem, merge pls?

@sfan5 sfan5 merged commit 3de5403 into minetest:master May 11, 2023
Andrey2470T pushed a commit to Andrey2470T/minetest that referenced this pull request May 31, 2023
Wuzzy2 pushed a commit to Wuzzy2/minetest that referenced this pull request Jul 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants