Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Increase ftos precision #13141

Merged
merged 3 commits into from Jan 12, 2023
Merged

Increase ftos precision #13141

merged 3 commits into from Jan 12, 2023

Conversation

TurkeyMcMac
Copy link
Contributor

Fixes #13138. This should be enough precision to preserve values exactly.

To do

This PR is Ready for Review.

How to test

Try this code:

local meta = ItemStack("air"):get_meta()
meta:set_float("1", 1.23456789)
assert(meta:get_string("1") == "1.23456788")
meta:set_float("2", 1.25)
assert(meta:get_string("2") == "1.25")

@TurkeyMcMac TurkeyMcMac merged commit 5f2925c into minetest:master Jan 12, 2023
LizzyFleckenstein03 pushed a commit to LizzyFleckenstein03/minetest that referenced this pull request Mar 7, 2023
@TurkeyMcMac @LizzyFleckenstein03
Increase ftos precision (minetest#13141)
2bb17fc
appgurueu pushed a commit to appgurueu/minetest that referenced this pull request May 2, 2023
@TurkeyMcMac @appgurueu
Increase ftos precision (minetest#13141)
e71a38d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sfan5 sfan5 sfan5 approved these changes

Assignees
No one assigned
Labels
Bugfix 🐛 PRs that fix a bug One approval ✅ ◻️ @ Server / Client / Env.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ftos precision is too low
2 participants
@TurkeyMcMac @sfan5