Android: Increase minimum SDK version to 21 #13205
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Target/compiled SDK version is increased to 33. Build Tools, NDK, and Gradle are also updated.
sfan5
added
Maintenance
rubenwardy
approved these changes
Feb 14, 2023
|
I updated |
|
Thank you for the merge! |
|
Matching commit for the native deps: minetest/minetest_android_deps@b68026f |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal of the PR
This PR increases minimum SDK version to 21, increases target/compiled SDK version to 33, and also updates Build Tools, NDK, and Gradle for Android build.
How does the PR work?
androidx.appcompat:appcompat: 1.5.1 -> 1.6.1Reasons for choosing 21 (Lollipop, Android 5.0) for the minimum SDK version:
From statistics collected here, these changes still cover around 99.4% of Android users globally.
I have tested this before and found that the minetest/minetest_android_deps still works with this higher version. It is optional to be the same version as this PR (NDK r25c), but note that it might need to be updated for the upcoming NDK r26.
Does it resolve any reported issue?
Resolves #13137
Comparisons between related "block" (voxel) games on the Google Play Store:
16(4.1, current),21(5.0, this PR)21(Android 5.0)26(Android 8.0)21(Android 5.0)21(Android 5.0)Does this relate to a goal in the roadmap?
I do not know.
To do
This PR is Ready for Review.
How to test