Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ASCII Logo is broken when running with --server --terminal CLI option #13287

Closed
AFCMS opened this issue Mar 6, 2023 · 19 comments · Fixed by #13876
Closed

ASCII Logo is broken when running with --server --terminal CLI option #13287

AFCMS opened this issue Mar 6, 2023 · 19 comments · Fixed by #13876
Labels

Comments

@AFCMS
Copy link
Contributor

AFCMS commented Mar 6, 2023

Minetest version
Minetest 5.7.0-dev-1f0d042-dirty (Linux)
Using Irrlicht 1.9.0mt10
Using LuaJIT 2.1.0-beta3
BUILD_TYPE=Release
RUN_IN_PLACE=1
USE_CURL=1
USE_GETTEXT=0
USE_SOUND=1
STATIC_SHAREDIR="."
OS / Hardware

Operating system: Ubuntu 22.04
CPU: Intel Core i3

Summary

image

Steps to reproduce

Run minetest server from CLI with the --terminal option. Wait until the server is fully started. See that the logo is broken.

@AFCMS AFCMS added the Unconfirmed bug Bug report that has not been confirmed to exist/be reproducible label Mar 6, 2023
@hlqkj
Copy link

hlqkj commented Mar 14, 2023

I can confirm this happens on Ubuntu 22.04 LTS.

@Zughy Zughy added Bug Issues that were confirmed to be a bug @ Startup / Config / Util Unconfirmed bug Bug report that has not been confirmed to exist/be reproducible Linux and removed Unconfirmed bug Bug report that has not been confirmed to exist/be reproducible Bug Issues that were confirmed to be a bug labels Apr 28, 2023
@Zughy
Copy link
Member

Zughy commented May 15, 2023

Cannot reproduce on Pop!_OS, i7, 5.8.0-dev

@AFCMS
Copy link
Contributor Author

AFCMS commented May 15, 2023

Could this be related to the terminal software used? I use the default GNOME one.

@Desour
Copy link
Member

Desour commented May 15, 2023

Can't reproduce either, using bash and gnome-terminal.
Edit: Oops, haven't read reproduction steps correctly.

You could try piping the stdout and stderr into a file and upload it here. And also try cat <file>.

@AFCMS
Copy link
Contributor Author

AFCMS commented May 15, 2023

Tested again with Fedora 38 and same problem.

2023-05-15.22-00-44.mp4

I also get the problem with the Kitty terminal emulator.

Tested with Bash, too.

@Zughy Zughy added Bug Issues that were confirmed to be a bug and removed Unconfirmed bug Bug report that has not been confirmed to exist/be reproducible labels May 15, 2023
@Zughy
Copy link
Member

Zughy commented May 15, 2023

@AFCMS only with --server or in general?

@Desour
Copy link
Member

Desour commented May 15, 2023

@AFCMS only with --server or in general?

Run minetest server

=> With --server.

Can reproduce.

@Zughy Zughy changed the title ASCII Logo is broken when running with --terminal CLI option under Linux ASCII Logo is broken when running with --server --terminal CLI option under Linux May 15, 2023
@AFCMS
Copy link
Contributor Author

AFCMS commented May 16, 2023

I was running with --server, but with minetestserver I get the same issue (just tested with latest master).

@AFCMS
Copy link
Contributor Author

AFCMS commented May 16, 2023

image

@Zughy
Copy link
Member

Zughy commented May 16, 2023

What I meant was, does the ASCII art explode even if you run it as a normal client?

@AFCMS
Copy link
Contributor Author

AFCMS commented May 16, 2023

If I run the client the ASCII are is fine.

If I add just the --terminal flag there is no terminal (I think the option is just ignored for non-servers) and the ASCII art is also fine.

@mrGoodWolf
Copy link

it happens mac too with version
Minetest 5.7.0 (OSX)
Using Irrlicht 1.9.0mt10
Using LuaJIT 2.1.0-beta3
BUILD_TYPE=Release
RUN_IN_PLACE=0
USE_CURL=1
USE_GETTEXT=1
USE_SOUND=1
STATIC_SHAREDIR="minetest.app/Contents/Resources"
STATIC_LOCALEDIR="minetest.app/Contents/Resources/locale"

2023-09-24.09-02-25.mov

@sfan5 sfan5 removed the Linux label Sep 24, 2023
@sfan5 sfan5 changed the title ASCII Logo is broken when running with --server --terminal CLI option under Linux ASCII Logo is broken when running with --server --terminal CLI option Sep 24, 2023
@srifqi
Copy link
Member

srifqi commented Sep 27, 2023

I can not reproduce this issue with Minetest 5.7.0 (as well as the recent master branch) on Windows 10 (10.0.19045) both in Command Prompt and in Windows PowerShell.

I also can not reproduce it with the recent master branch on Ubuntu 22.04.3 LTS (running on VirtualBox).

         __.               __.                 __.
  _____ |__| ____   _____ /  |_  _____  _____ /  |_
 /     \|  |/    \ /  __ \    _\/  __ \/   __>    _\
|  Y Y  \  |   |  \   ___/|  | |   ___/\___  \|  |
|__|_|  /  |___|  /\______>  |  \______>_____/|  |
      \/ \/     \/         \/                  \/

@sfan5
Copy link
Member

sfan5 commented Sep 27, 2023

AFAIK Windows doesn't support the ncurses --terminal so that's to be expected.

@mrGoodWolf
Copy link

Btw it does it on debian

@rubenwardy
Copy link
Member

rubenwardy commented Oct 8, 2023

I suggest removing the ASCII logo or just closing this issue. This isn't worth spending any time fixing

@Zughy
Copy link
Member

Zughy commented Oct 8, 2023

For how nice it can be, I agree with the removal - considering the few issues we've seen

@AFCMS
Copy link
Contributor Author

AFCMS commented Oct 8, 2023

I suggest removing the ASCII logo or just closing this issue. This isn't worth spending any time fixing

Only when using with --terminal ? Because I really like the ASCII logo :(

@hlqkj
Copy link

hlqkj commented Oct 8, 2023

As long as the cause of the broken ASCII logo doesn't break anything else in the output when using --terminal, I guess it can just be removed when using that switch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
8 participants