New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Return shadow_sky_body_orbit_tilt setting #13340
Conversation
Used as a default value when the game does not change the value via API (e.g. legacy server)
@Desour the problem was in not having a default value in SkyboxParams when deserialization fails of skips the value. I've returned the setting to act as a drop-in value in these cases. |
Are we sure we want to introduce a setting that only works on older server (this is mostly opaque to the user and will cause confusion)? Why not just hardcode 60 as default? |
It will also work for games/servers that don't change orbit_tilt via API. |
Looks good (minus the warning) |
src/skyparams.h
Outdated
@@ -19,6 +19,8 @@ with this program; if not, write to the Free Software Foundation, Inc., | |||
|
|||
#pragma once | |||
|
|||
#include <cmath> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks unused
I see. Didn't review the code prior to commenting. |
I've added an |
should be documented in lua_api.txt that the field can be nil. |
Expanded the documentation for the parameter, explaining the default behavior and changing the values. |
Used as a default value when the game does not change the value via API (e.g. legacy server)
Fixes #13302.
To do
This PR is Ready for Review.
How to test
shadow_sky_body_orbit_tilt = 60