Fix rotation of 4dir in schematic placement #13432
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wsor4035
added
Bugfix 🐛
|
Please add this to the 5.7.1 milestone. (If a bugfix release is planned.) It fixes a new feature in 5.7.0 which I screwed up due to my own incompetence (sorry ...). |
|
I placed a few
|
|
The bug manifests only if the schematic is placed with 90°, 180° or 270° rotation. Try again when you place the schematic with rotation. Reproduced in d197ff0. |
Andrey2470T
pushed a commit
to Andrey2470T/minetest
that referenced
this pull request
May 31, 2023
Wuzzy2
added a commit
to Wuzzy2/minetest
that referenced
this pull request
Jul 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sadly, the 4dir / color4dir paramtype2 is incorrectly rotated when a 4dir node is placed in a schematic. The rotation code had a bug.
This PR fixes the rotation of 4dir and color4dir nodes if placed in a schematic.
How to test:
Place a schematic with 4dir nodes.