Reduce minetest.after
time complexity and provide ordering guarantee
#13477
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adopted (essentially just trivially rebased) #12043.
The following discussion from @savilli was still unresolved. savilli pointed out that jobs are not completely removed from the data structure, but rather updated to be "dummy" jobs, thus deferring the cost of removing them. The downsides of not removing dummy jobs are the following:
For regular use of jobs and cancellation, none of this will be an issue. On the other hand, implementing immediate removal comes with the following issues: