Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Raise and clean up _WIN32_WINNT constant #13480

Merged
merged 1 commit into from May 11, 2023
Merged

Raise and clean up _WIN32_WINNT constant #13480

merged 1 commit into from May 11, 2023

Conversation

sfan5
Copy link
Member

@sfan5 sfan5 commented May 3, 2023

@sfan5 sfan5 added Maintenance Tasks to keep the codebase and related parts in order, including architectural improvements Windows labels May 3, 2023
@rubenwardy
Copy link
Member

rubenwardy commented May 3, 2023 •
edited

Note that 0x0601 means Windows 7.

Would be good to either have this as a constant or add a comment

@sfan5
Copy link
Member Author

sfan5 commented May 3, 2023

Meh. IMO anyone technically inclined enough to worry about build systems details can easy find the docs himself.

SmallJoker
SmallJoker approved these changes May 11, 2023
View reviewed changes
Copy link
Member

@SmallJoker SmallJoker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The MSVC build passes, hence LGTM.

@sfan5 sfan5 merged commit 15445a0 into minetest:master May 11, 2023
13 checks passed
@sfan5 sfan5 deleted the winnt branch May 11, 2023 20:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SmallJoker SmallJoker SmallJoker approved these changes

Assignees
No one assigned
Labels
Maintenance Tasks to keep the codebase and related parts in order, including architectural improvements One approval ✅ ◻️ Windows
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@sfan5 @rubenwardy @SmallJoker